Add missing repo to enable building with -Ddremio.oss-only=true - #72
Open
pvallone wants to merge 1 commit into
Open
Add missing repo to enable building with -Ddremio.oss-only=true#72pvallone wants to merge 1 commit into
pvallone wants to merge 1 commit into
Conversation
Author
|
I did notice this bit of code from this part of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README mentions here that Dremio can be built with only OSS dependencies by specifying the
-Ddremio.oss-only=trueflag. Currently, this fails with the error below becausecom.dremio.data:dremio-tpch-sample-datacan't be pulled from thedremio-publicrepo. This PR makes thedremio-freerepo accessible to the build. It seems like an alternative (and perhaps preferable) solution would be to addcom.dremio.data:dremio-tpch-sample-datato thedremio-publicrepo, but I'm guessing only the Dremio team has the ability to add things to that repo.Without this change, the build fails with the error below when running this command:
mvn clean install -DskipTests -Ddremio.oss-only=true[ERROR] Failed to execute goal on project dremio-sabot-kernel: Could not resolve dependencies for project com.dremio.sabot:dremio-sabot-kernel:jar:21.2.0-202205262146080444-038d6d1b: Could not find artifact com.dremio.data:dremio-tpch-sample-data:jar:1.0.0 in dremio-public (https://maven.dremio.com/public/) -> [Help 1]There are several issues open about this build failure. Here's one such example.